Skip to content

Reverted route validation #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 28, 2023
Merged

Reverted route validation #1278

merged 8 commits into from
Jul 28, 2023

Conversation

gavin-aguiar
Copy link
Contributor

Description

Reverting route validation from the python worker. This will be adding in the library

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jun 28, 2023 •
edited
Loading

Codecov Report

Merging #1278 (0680859) into dev (242853b) will decrease coverage by 51.97%.
The diff coverage is 0.00%.

❗ Current head 0680859 differs from pull request most recent head 33370c8. Consider uploading reports for the commit 33370c8 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1278       +/-   ##
===========================================
- Coverage   84.25%   32.29%   -51.97%     
===========================================
  Files          34       34               
  Lines        1925     1917        -8     
  Branches      366      364        -2     
===========================================
- Hits         1622      619     -1003     
- Misses        231     1297     +1066     
+ Partials       72        1       -71
Flag Coverage Δ
unittests 32.29% <0.00%> (-51.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
azure_functions_worker/functions.py 24.44% <0.00%> (-71.84%) ⬇️

... and 22 files with indirect coverage changes

vrdmr
vrdmr approved these changes Jul 13, 2023
View reviewed changes
@gavin-aguiar gavin-aguiar merged commit f9bf8ff into dev Jul 28, 2023
@gavin-aguiar gavin-aguiar deleted the gaaguiar/remove_route_validation branch July 28, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrdmr vrdmr vrdmr approved these changes

@pdthummar pdthummar pdthummar approved these changes

@YunchuWang YunchuWang Awaiting requested review from YunchuWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gavin-aguiar @vrdmr @pdthummar